You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The && subdb.prefix here should not be needed, because at this point we've already determined subdb to be a subleveldown instance and such an instance always has a prefix (even when the user passes in an empty prefix).
If it doesn't have a prefix, that's either a bug or incorrect usage (someone modifying the prefix). Either way it should be surfaced as an error, which is preferable to hitting the else branch on L94, which can result in an incorrect self.leveldown.
The text was updated successfully, but these errors were encountered:
subleveldown/leveldown.js
Lines 89 to 96 in 3e8c1af
The
&& subdb.prefix
here should not be needed, because at this point we've already determinedsubdb
to be a subleveldown instance and such an instance always has a prefix (even when the user passes in an empty prefix).If it doesn't have a prefix, that's either a bug or incorrect usage (someone modifying the prefix). Either way it should be surfaced as an error, which is preferable to hitting the
else
branch on L94, which can result in an incorrectself.leveldown
.The text was updated successfully, but these errors were encountered: