Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move wrap_litserve_start to utils #195

Closed
aniketmaurya opened this issue Aug 6, 2024 · 5 comments · Fixed by #201
Closed

move wrap_litserve_start to utils #195

aniketmaurya opened this issue Aug 6, 2024 · 5 comments · Fixed by #201
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aniketmaurya
Copy link
Collaborator

aniketmaurya commented Aug 6, 2024 •
edited by Borda
Loading

I would rather reserve conftest for fixtures and this (seems to be) general functionality move to another utils module

Originally posted by @Borda in #190 (comment)
@aniketmaurya aniketmaurya added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 7, 2024
@ankitsharma07
Copy link
Contributor

hey i would like to take this up..

@aniketmaurya
Copy link
Collaborator Author

feel free to go ahead @ankitsharma07 🚀

@ankitsharma07
Copy link
Contributor

feel free to go ahead @ankitsharma07 🚀

thanks.

@aniketmaurya
Copy link
Collaborator Author

@ankitsharma07 let me know if you need any help.

@ankitsharma07 ankitsharma07 mentioned this issue Aug 10, 2024
Merged
@ankitsharma07
Copy link
Contributor

@aniketmaurya you can close this one

@aniketmaurya aniketmaurya linked a pull request Aug 12, 2024 that will close this issue
moved wrap_litserve_start to utils #201
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

moved wrap_litserve_start to utils ankitsharma07/LitServe
2 participants
@ankitsharma07 @aniketmaurya