Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in actions/upload-artifact@v3 makes check-package.yml always fail #302

Closed
shino16 opened this issue Sep 2, 2024 · 2 comments · Fixed by #303 or Lightning-AI/pytorch-lightning#20304
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@shino16
Copy link
Contributor

shino16 commented Sep 2, 2024

🐛 Bug

From September 2nd, 2024, we will no longer include hidden files and folders as part of the default upload of the v3 and v4 upload-artifact actions.
https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

This change in actions/upload-artifact@v3 causes check-package.yml to fail.

Example and Explanation

Failed CI

init-store did the following:

- run: mkdir dist && touch dist/.placeholder
- name: Upload 📤
uses: actions/upload-artifact@v3
with:
name: ${{ inputs.artifact-name }}
path: dist

.placeholder was ignored, so this resulted in the following message:

Warning: No files were found with the provided path: dist. No artifacts will be uploaded.

The subsequent job pkg-build tried to download artifacts under the same name in pkg-create:

- name: Create package 📦
uses: ./.cicd/.github/actions/pkg-create
with:
artifact-name: ${{ inputs.artifact-name }}

- name: Download 📥 previous packages
if: ${{ inputs.artifact-name != '' }}
uses: actions/download-artifact@v3
with:
name: ${{ inputs.artifact-name }}
path: pypi

and produced the following error message:

Error: Unable to find any artifacts for the associated workflow

Possible Solution

Set include-hidden-files to true.
https://github.com/actions/upload-artifact/blob/b18b1d32f3f31abcdc29dee3f2484801fe7822f4/action.yml#L43-L47

@Borda
Copy link
Member

Borda commented Sep 2, 2024

@shino16 thank ou for this report and quick fix!
the patch was merged and all just released as 0.11.7

@shino16
Copy link
Contributor Author

shino16 commented Sep 3, 2024

Thank you for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants