From 4e9fa7b59eeb41c4c751f535dc26b1c72306f7d4 Mon Sep 17 00:00:00 2001 From: Ruben Taelman Date: Wed, 28 Aug 2024 13:20:48 +0200 Subject: [PATCH] Fix node-gyp building on MacOS --- .github/workflows/ci.yml | 9 ++++----- binding.gyp | 4 +++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 502fa3d..b2115f9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,12 +10,11 @@ jobs: test: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-14] node-version: - 18.x - - 20.x - - 22.x steps: - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v3 @@ -34,9 +33,9 @@ jobs: **/node_modules .rdf-test-suite-cache .rdf-test-suite-ldf-cache - key: ${{ runner.os }}-test-modules-${{ hashFiles('**/package-lock.json') }} + key: ${{ runner.os }}-${{ runner.node-version }}-test-modules-${{ hashFiles('**/package-lock.json') }} - name: Install dependencies - run: npm install + run: npm install --verbose - name: Run tests run: npm run test - name: Run bin diff --git a/binding.gyp b/binding.gyp index 3003f32..95ab858 100644 --- a/binding.gyp +++ b/binding.gyp @@ -44,9 +44,11 @@ "xcode_settings": { "GCC_ENABLE_CPP_RTTI": "YES", "GCC_ENABLE_CPP_EXCEPTIONS": "YES", + "GCC_PREPROCESSOR_DEFINITIONS": "_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION=1", "OTHER_CFLAGS": [ "-stdlib=libc++", - "-Wno-register" + "-Wno-register", + "-std=c++17", ], }, },