-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many formatting errors after man page conversion to adoc #3032
Comments
[Hans Unzner]
It's mostly when bold formatting is involved:
While some bold formatting were removed intentionally, the
classicladder.9 ones you show seem to be unintentintional.
I could have spend more time comparing the before and after versions,
but we wanted to complete the migration before the LinuxCNC developer
gathering were over and decided to fix any required cleanup
afterwords. Very glad to see you are able to assist in tracking down
any problems. :)
…--
Happy hacking
Petter Reinholdtsen
|
The problem are strings composed of Also some asteriskes appeared before the double colon See here the fix for the first man pages: https://github.com/LinuxCNC/linuxcnc/pull/3045/files @petterreinholdtsen maybe we can fix this by applying an intelligent regular expression on it? |
[Hans Unzner]
@petterreinholdtsen maybe we can fix this by applying an intelligent
regular expression on it?
Feel free to try. I used pandoc to do the conversion, and hoped it
would do a good enough job. :)
|
I was hoping you can help with your expertise ;-)
It seems that pandoc has some problems with the inline formatting. Maybe you can report that? |
@petterreinholdtsen I have now fixed a few man pages and I think you could also fix some. Otherwise I tend to revert the converted man pages because the goal was to simplify the maintenance of the man pages and not to introduce a huge amount of work to fix the errorneous converted man pages. |
Is this fixed now? |
50% of the man9 pages are fine (double checked), the rest probably as well. But you can't check it this way unfortunately because of #3031 |
I think we are mostly stuck with the man pages PRs of mine still failing on sid. |
#3031 is showing as closed now? |
Yes, the docs are up to date on the website 🎉 |
So, what needs to be done to close this issue? |
Spent some hours in manually comparing man pages before and after # 1376. |
I wonder if an AI could be asked to do the job? |
I don't know how to give an AI two lists of files.... |
Since #1376 (which makes the man pages being generated from adoc sources, wich is a great improvement!)
some of them have not ben converted correctly.
So please do not update the man pages until they are fixed.
Here is a list of the differences of the man9 man pages:
It's mostly when bold formatting is involved:
Unfortunately due to #3031 it is currently not possible to inspect the new generated man pages on the web site. You only can check this on a local build.
The text was updated successfully, but these errors were encountered: