Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Jitpack builds failing #152

Closed
kaneelyster opened this issue Jan 22, 2020 · 5 comments
Closed

Android Jitpack builds failing #152

kaneelyster opened this issue Jan 22, 2020 · 5 comments

Comments

@kaneelyster
Copy link

Refer to https://jitpack.io/#LiquidPlayer/LiquidCore

From 0.70 onward the Android Jitpack builds are failing, causing gradle sync failures when trying to use 0.7.0+ in my project.

The alternative of using % npm i -g liquidcore-cli yields the same gradle sync failures.

@ericwlange
Copy link
Member

Jitpack has been deprecated from 0.7.0+ because it requires a deprecated gradle plugin (see #128). Please remove the implementation line for jitpack. The input.gradle file manages downloading the artifacts.

@kaneelyster
Copy link
Author

@ericwlange Apologies for sounding dumb, but where do I find the implementation line for jitpack? Are you referring to maven { url 'https://jitpack.io' } under my project's top-level build.gradle?

What I have tried is to remove implementation 'com.github.LiquidPlayer:LiquidCore:0.7.0' from my app-level build.gradle to no avail. Changing liquidcore.build.gradle to use 0.6.2 works fine, but 0.7.0 fails.

@ericwlange
Copy link
Member

Remove everything related to JitPack: both maven { url 'https://jitpack.io' } and implementation 'com.github.LiquidPlayer:LiquidCore:0.7.0'.

Jitpack is no longer supported with LiquidCore.

Instead, follow the installation instructions on either the main README if you are using Node.js functionality or the updated README for just using the JavaScript engine.

From now on (or until I find a better way), distribution is happening through npm, so you can't skip the npm setup steps.

@kaneelyster
Copy link
Author

Thank you, that cleared it up.

I also had to add the following to the top-level build.gradle

buildscript {
    dependencies {
        classpath 'de.undercouch:gradle-download-task:1.2'
    }
}
ext {
    Download = de.undercouch.gradle.tasks.download.Download
    download = download
}

and this to the module's

apply plugin: 'de.undercouch.download'

to get the Gradle Download Task dependency working.

@ericwlange
Copy link
Member

@kaneelyster Interesting -- I haven't needed to do that. Let me investigate. Thanks! Glad you got it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants