Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unused payload properties can increase overall parsing of the messages #5212

Closed
shuse2 opened this issue Apr 29, 2020 · 0 comments
Closed

Unused payload properties can increase overall parsing of the messages #5212

shuse2 opened this issue Apr 29, 2020 · 0 comments

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Apr 29, 2020

Description

Currently lisk framework, and lisk p2p checks the size of the message and the validity of the used message. However, unused payloads were not strictly checked to reject them to provide the flexibility on the custom modules. However, the unused payloads can increase the parsing of the message even within the message size.

Expected behavior

While receiving the message through network, it should check if there are additional contents.
If a peer sends message with additional content, the peer should be banned, and not accept further connection or message.

Actual behavior

Currently, there are no additional contents check

Steps to reproduce

Send the p2p message which is not specified in the schema.

Which version(s) does this affect? (Environment, OS, etc...)

2.1-

@shuse2 shuse2 closed this as completed Apr 29, 2020
@shuse2 shuse2 added this to the Sprint 18 milestone Apr 29, 2020
@karmacoma karmacoma changed the title unused payload properties can increase overall parsing of the messages Unused payload properties can increase overall parsing of the messages Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants