Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Schemas do not require fields that should be required #8474

Closed
Tracked by #7226
shuse2 opened this issue May 22, 2023 · 0 comments
Closed
Tracked by #7226

Schemas do not require fields that should be required #8474

shuse2 opened this issue May 22, 2023 · 0 comments
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented May 22, 2023

Expected behavior

All schema should have required property especially for the ones used for the protocol

Actual behavior

Some schema does not have required property where needed. For example,
https://github.com/LiskHQ/lisk-sdk/blob/89e7504ef5eb6183aefe576a93be3d6052e56038/framework/src/modules/auth/schemas.ts#L107-L157

Steps to reproduce

Check required property for all the schemas

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-beta.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants