Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Message verification command fails on verification #8495

Closed
Tracked by #7226
ishantiw opened this issue May 25, 2023 · 3 comments
Closed
Tracked by #7226

Message verification command fails on verification #8495

ishantiw opened this issue May 25, 2023 · 3 comments
Assignees
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented May 25, 2023

Expected behavior

MessageRecoveryCommand's verification of inclusion proof on outboxRoot is using incorrect parameters. Query data should not be pre-hashed.

Actual behavior

MessageRecoveryCommand's verify parameters are pre-hashed.

Steps to reproduce

Submit messageRecovery transaction and it will fail with Message recovery proof of inclusion is not valid

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-beta.1

@sitetester
Copy link
Contributor

LIP 54

Let RMTVerify be the verifyDataBlock function specified in the appendix C of LIP 0031.

If we come to conclusion that verifyProof should be used instead, then LIP will also need to be updated.

@mitsuaki-u
Copy link
Contributor

The function used verifyDataBlock was found to be correct as per LIP

@mitsuaki-u mitsuaki-u changed the title MessageRecoveryCommand is calling incorrect function for verifying inclusionProof Message verification command fails on verification Aug 3, 2023
@mitsuaki-u
Copy link
Contributor

Verification working in unit tests. Further testing required on running network.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants