Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update unit test of removeSupportAllNFTs method of NFT module #8982

Closed
Tracked by #7245
Incede opened this issue Sep 14, 2023 · 0 comments
Closed
Tracked by #7245

Update unit test of removeSupportAllNFTs method of NFT module #8982

Incede opened this issue Sep 14, 2023 · 0 comments
Assignees
Milestone

Comments

@Incede
Copy link
Contributor

Incede commented Sep 14, 2023

Description

  • The test for removeSupportAllNFTs should work by 1) creating a random chainID, 2) saving that chainID to the supportedNFTsStore store, 3) removing the support for that chainID, and 4) checking that the supportedNFTsStore no longer contains the chainID key.
  • But in step 2, it incorrectly saves a random wrong value to the supportedNFTsStore store instead of using the chainID variable
  • By removing the call to supportedNFTsStore.save, the test still passes which is undesirable.

Acceptance Criteria

  • Replace the call to supportedNFTsStore.save’s utils.getRandomBytes(LENGTH_CHAIN_ID) argument with the chainID variable.
  • Add a check in the test that ensures that the NFT is supported before removing it.

Please describe the conditions which must be met for this issue to close

Additional Information

release/6.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants