From a41b8ae0c2f1f00cc2e6e5504b0566ae5228871a Mon Sep 17 00:00:00 2001 From: Incede <33103370+Incede@users.noreply.github.com> Date: Thu, 27 Jul 2023 07:13:31 +0200 Subject: [PATCH 1/2] Fix build --- framework/src/modules/nft/internal_method.ts | 2 -- framework/src/modules/nft/module.ts | 3 +-- framework/src/modules/nft/types.ts | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/framework/src/modules/nft/internal_method.ts b/framework/src/modules/nft/internal_method.ts index 6b87cbb7aea..95cd702c0de 100644 --- a/framework/src/modules/nft/internal_method.ts +++ b/framework/src/modules/nft/internal_method.ts @@ -22,7 +22,6 @@ import { UserStore } from './stores/user'; import { CROSS_CHAIN_COMMAND_NAME_TRANSFER, MODULE_NAME_NFT, NFT_NOT_LOCKED } from './constants'; import { EscrowStore } from './stores/escrow'; import { TransferCrossChainEvent } from './events/transfer_cross_chain'; -import { CCM_STATUS_OK } from '../token/constants'; import { crossChainNFTTransferMessageParamsSchema } from './schemas'; export class InternalMethod extends BaseMethod { @@ -166,7 +165,6 @@ export class InternalMethod extends BaseMethod { CROSS_CHAIN_COMMAND_NAME_TRANSFER, receivingChainID, messageFee, - CCM_STATUS_OK, codec.encode(crossChainNFTTransferMessageParamsSchema, { nftID, senderAddress, diff --git a/framework/src/modules/nft/module.ts b/framework/src/modules/nft/module.ts index 5a13661163f..a772194a149 100644 --- a/framework/src/modules/nft/module.ts +++ b/framework/src/modules/nft/module.ts @@ -18,7 +18,7 @@ import { validator } from '@liskhq/lisk-validator'; import { GenesisBlockExecuteContext } from '../../state_machine'; import { ModuleInitArgs, ModuleMetadata } from '../base_module'; import { BaseInteroperableModule } from '../interoperability'; -import { InteroperabilityMethod } from '../token/types'; +import { InteroperabilityMethod, FeeMethod, GenesisNFTStore, TokenMethod } from './types'; import { NFTInteroperableMethod } from './cc_method'; import { NFTEndpoint } from './endpoint'; import { AllNFTsFromChainSupportedEvent } from './events/all_nfts_from_chain_suported'; @@ -59,7 +59,6 @@ import { EscrowStore } from './stores/escrow'; import { NFTStore } from './stores/nft'; import { SupportedNFTsStore } from './stores/supported_nfts'; import { UserStore } from './stores/user'; -import { FeeMethod, GenesisNFTStore, TokenMethod } from './types'; import { CrossChainTransferCommand as CrossChainTransferMessageCommand } from './cc_commands/cc_transfer'; import { TransferCrossChainCommand } from './commands/transfer_cross_chain'; import { TransferCommand } from './commands/transfer'; diff --git a/framework/src/modules/nft/types.ts b/framework/src/modules/nft/types.ts index d56e3343ebb..64ccefa1a54 100644 --- a/framework/src/modules/nft/types.ts +++ b/framework/src/modules/nft/types.ts @@ -27,7 +27,6 @@ export interface InteroperabilityMethod { crossChainCommand: string, receivingChainID: Buffer, fee: bigint, - status: number, parameters: Buffer, timestamp?: number, ): Promise; From af1a47b6b8e72fd9d63ad8ae38ed3a7d53be6ee2 Mon Sep 17 00:00:00 2001 From: Incede <33103370+Incede@users.noreply.github.com> Date: Thu, 27 Jul 2023 07:19:12 +0200 Subject: [PATCH 2/2] Update tests --- framework/test/unit/modules/nft/internal_method.spec.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/framework/test/unit/modules/nft/internal_method.spec.ts b/framework/test/unit/modules/nft/internal_method.spec.ts index 4817a89d45d..72e158fa376 100644 --- a/framework/test/unit/modules/nft/internal_method.spec.ts +++ b/framework/test/unit/modules/nft/internal_method.spec.ts @@ -40,7 +40,6 @@ import { TransferCrossChainEventData, } from '../../../../src/modules/nft/events/transfer_cross_chain'; import { DestroyEvent, DestroyEventData } from '../../../../src/modules/nft/events/destroy'; -import { CCM_STATUS_OK } from '../../../../src/modules/token/constants'; import { crossChainNFTTransferMessageParamsSchema } from '../../../../src/modules/nft/schemas'; describe('InternalMethod', () => { @@ -294,7 +293,6 @@ describe('InternalMethod', () => { CROSS_CHAIN_COMMAND_NAME_TRANSFER, receivingChainID, messageFee, - CCM_STATUS_OK, ccmParameters, ); }); @@ -363,7 +361,6 @@ describe('InternalMethod', () => { CROSS_CHAIN_COMMAND_NAME_TRANSFER, receivingChainID, messageFee, - CCM_STATUS_OK, ccmParameters, ); }); @@ -449,7 +446,6 @@ describe('InternalMethod', () => { CROSS_CHAIN_COMMAND_NAME_TRANSFER, receivingChainID, messageFee, - CCM_STATUS_OK, ccmParameters, ); }); @@ -525,7 +521,6 @@ describe('InternalMethod', () => { CROSS_CHAIN_COMMAND_NAME_TRANSFER, receivingChainID, messageFee, - CCM_STATUS_OK, ccmParameters, ); });