Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Refactor the chain module initialization to simplify and maintainable #2866

Closed
nazarhussain opened this issue Feb 12, 2019 · 0 comments · Fixed by #2887
Closed

Refactor the chain module initialization to simplify and maintainable #2866

nazarhussain opened this issue Feb 12, 2019 · 0 comments · Fixed by #2887

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Feb 12, 2019

Expected behavior

The steps to initialize chain module must be very clear and readable, that helps to test and maintain the key business logic of the application.

Actual behavior

Currenlty there is a nested structure of async.auto causing ambiguity in code understanding and readability.

https://github.com/LiskHQ/lisk/blob/25354edd4c46b9d4c114c3a823f03db822167e81/framework/src/modules/chain/chain.js#L138
https://github.com/LiskHQ/lisk/blob/25354edd4c46b9d4c114c3a823f03db822167e81/framework/src/modules/chain/chain.js#L516

Which version(s) does this affect? (Environment, OS, etc...)

1.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.