Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Typo on peer dns lookup resolution code #2961

Closed
2snEM6 opened this issue Feb 25, 2019 · 0 comments · Fixed by #2962
Closed

Typo on peer dns lookup resolution code #2961

2snEM6 opened this issue Feb 25, 2019 · 0 comments · Fixed by #2962
Assignees

Comments

@2snEM6
Copy link
Contributor

2snEM6 commented Feb 25, 2019

Expected behavior

DNS lookups should be successfull on valid peers

Actual behavior

DNS lookups are failing due to a typo in the code:
https://github.com/LiskHQ/lisk/blob/a46d08946c66ca7c8806e9929f75d5a8b7a27f3b/framework/src/modules/chain/init_steps/lookup_peers_ips.js#L21
peer.id should be written as peer.ip

Steps to reproduce

Execute the node and it will crash due to this

Which version(s) does this affect? (Environment, OS, etc...)

development branch

@2snEM6 2snEM6 self-assigned this Feb 25, 2019
MaciejBaj added a commit that referenced this issue Feb 25, 2019
Fix typo on dns lookup resolution code - Closes #2961
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant