Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Peer objects are not being converted to string correctly #2964

Closed
2snEM6 opened this issue Feb 25, 2019 · 0 comments · Fixed by #2966
Closed

Peer objects are not being converted to string correctly #2964

2snEM6 opened this issue Feb 25, 2019 · 0 comments · Fixed by #2966
Assignees
@2snEM6
Labels
type: bug

Comments

@2snEM6
Copy link
Contributor

2snEM6 commented Feb 25, 2019

Expected behavior

an instance of Peer class (modules/chain/logic/peers) should have a string property
representing the peer information in the next format:
ip:port
For example: 127.0.0.1:4000

Actual behavior

Peers are being stringified to for example [object Object]:7001 and SocketCluster is crashing because of it.

Steps to reproduce

Run application on development branch

Which version(s) does this affect? (Environment, OS, etc...)

development branch
@2snEM6 2snEM6 self-assigned this Feb 25, 2019
@2snEM6 2snEM6 mentioned this issue Feb 25, 2019
Merged
MaciejBaj added a commit that referenced this issue Feb 25, 2019
@MaciejBaj
Merge pull request #2966 from LiskHQ/2964-peer_object_incorrectly_str…
8d62217 
…ingified

Fix Peer object string address - Closes #2964
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@2snEM6 2snEM6

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Peer object string address - Closes #2964 LiskArchive/lisk-sdk
1 participant
@2snEM6