You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Use named parameters instead of an array for better readability. For example:
this calculateSupply: action => blockReward.calcSupply(action.height), instead of this calculateSupply: action => blockReward.calcSupply(action.params[0])
Improve redundant code on modules/chain.index.js for actions declaration.
Actual behavior
Chain actions currently present the following issues:
Arguments are passed from actions interface to logic in form of an array which is confusing for the developer.
Actions declaration code on modules/chain/index.js seems redundant.
Steps to reproduce
Which version(s) does this affect? (Environment, OS, etc...)
The text was updated successfully, but these errors were encountered:
Expected behavior
this
calculateSupply: action => blockReward.calcSupply(action.height)
, instead of thiscalculateSupply: action => blockReward.calcSupply(action.params[0])
modules/chain.index.js
for actions declaration.Actual behavior
Chain actions currently present the following issues:
Arguments are passed from actions interface to logic in form of an array which is confusing for the developer.
Actions declaration code on
modules/chain/index.js
seems redundant.Steps to reproduce
Which version(s) does this affect? (Environment, OS, etc...)
The text was updated successfully, but these errors were encountered: