Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move fee as static property of the transaction implementation #3521

Closed
nazarhussain opened this issue May 6, 2019 · 2 comments
Closed

Move fee as static property of the transaction implementation #3521

nazarhussain opened this issue May 6, 2019 · 2 comments

Comments

@nazarhussain
Copy link
Contributor

Expected behavior

With every custom transaction we should be able to specify some distinct fee for it. And that should not involve passing any configuration at application level.

class CustomTransaction extends BaseTransaction {
   static meta = {fee: 100000}
}

That will be accessible through CustomTransaction.meta.fee in element and in framework where ever required.

Actual behavior

Currently transaction fee is defined as constants in the transactions element as well as framework constants. Which makes it impossible to create and register new transaction.

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0

@nazarhussain
Copy link
Contributor Author

We also look into this endpoint, either to remove the constants or somehow return the fee of custom registered transactions.

https://github.com/LiskHQ/lisk-sdk/blob/86db5cabc562214958d8d1487fb99ddd4ee24903/framework/src/modules/http_api/controllers/node.js#L85-L93

@shuse2
Copy link
Collaborator

shuse2 commented Jul 5, 2019

Superseded by #3860

@shuse2 shuse2 closed this as completed Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants