Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Transactions not being instantiated when receiving a block #3535

Closed
2snEM6 opened this issue May 7, 2019 · 0 comments
Closed

Transactions not being instantiated when receiving a block #3535

2snEM6 opened this issue May 7, 2019 · 0 comments
Assignees

Comments

@2snEM6
Copy link
Contributor

2snEM6 commented May 7, 2019

Expected behavior

Valid blocks with valid transactions should be processed successfully

Actual behavior

When receiving a block from a peer, a call to objectNormalize on the block is performed framework/src/modules/chain/submodules/transport.js:570. This function also used in many places elsewhere expects transactions to be instantiated using their class implementations but the current code doesn't do this and it crashes.

Also, when broadcasting a block transactions are not explicitly converted to JSON by calling .toJSON() transaction's class function. Socketcluster is somewhat stringifying the transaction ES6 class and parsing it at JSON before sending.

Steps to reproduce

Run to nodes, one forging, one now and check the how framework/src/modules/chain/submodules/transport.js:570 throws an error.

Which version(s) does this affect? (Environment, OS, etc...)

release/2.0.0

@2snEM6 2snEM6 self-assigned this May 7, 2019
shuse2 added a commit that referenced this issue May 8, 2019
…antiated_on_block_receive

Transactions not being instantiated on block receive - Closes #3535
@shuse2 shuse2 closed this as completed May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants