Combine all the rounds related logic into one module and expose used functionality #3615

shuse2 · 2019-05-14T14:41:56Z

Expected behavior

Within round module, it should not have any external dependency, and only exposing the used function from other module

round.js
rounds_information.js
rounds.js
delegates.js

Actual behavior

Round logic spread across the chain module

…ted-logic-into-one-module Combine all the rounds related logic into one module and expose used functionality - Closes #3615

shuse2 added type: refactoring framework/chain labels May 14, 2019

shuse2 assigned pablitovicente May 16, 2019

pablitovicente mentioned this issue May 17, 2019

Combine all the rounds related logic into one module and expose used functionality - Closes #3615 #3658

Merged

shuse2 closed this as completed in #3658 May 22, 2019

shuse2 added a commit that referenced this issue May 22, 2019

Merge pull request #3658 from LiskHQ/3615-combine-all-the-rounds-rela…

008d6d2

…ted-logic-into-one-module Combine all the rounds related logic into one module and expose used functionality - Closes #3615

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combine all the rounds related logic into one module and expose used functionality #3615

Combine all the rounds related logic into one module and expose used functionality #3615

shuse2 commented May 14, 2019

Combine all the rounds related logic into one module and expose used functionality #3615

Combine all the rounds related logic into one module and expose used functionality #3615

Comments

shuse2 commented May 14, 2019

Expected behavior

Actual behavior