Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Transaction pool logs redundant info logs #4072

Closed
ManuGowda opened this issue Aug 13, 2019 · 1 comment
Closed

Transaction pool logs redundant info logs #4072

ManuGowda opened this issue Aug 13, 2019 · 1 comment
Assignees

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Aug 13, 2019

Expected behavior

Instead of actively logging transaction pool data, the better approach would be to log the transaction pool info when we receive any transaction for processing, this way we can avoid redundantly logging Transaction pool - received size: 0 validated size: 0 verified size: 0 pending size: 0 ready size: 1

Actual behavior

Active logging of transaction pool makes the info logs redundant

Steps to reproduce

  • Deploy 2.3.0-alpha.1
  • Monitor logs

Which version(s) does this affect? (Environment, OS, etc...)

2.3.0

@shuse2
Copy link
Collaborator

shuse2 commented Aug 13, 2019

This message is only logged when a transaction is removed from transaction pool. https://github.com/LiskHQ/lisk-sdk/blob/release/2.3.0/framework/src/modules/chain/transaction_pool/transaction_pool.js#L197

Therefore, it only log when new block, expire block or invalid transactions filters remove the transaction from the pool passively

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants