Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

signTransaction in lisk-transactions has wrong return type #6245

Closed
mitsuaki-u opened this issue Mar 11, 2021 · 1 comment
Closed

signTransaction in lisk-transactions has wrong return type #6245

mitsuaki-u opened this issue Mar 11, 2021 · 1 comment
Labels
status: invalid

Comments

@mitsuaki-u
Copy link
Contributor

Expected behavior

Should return a defined type representative of transaction object

Actual behavior

Returns Record<string, unknown which is inconvenient as the return object must be casted everywhere this function is used.

Steps to reproduce

Check return type of signTransaction

Which version(s) does this affect? (Environment, OS, etc...)

5.1
@shuse2
Copy link
Collaborator

shuse2 commented Jul 19, 2022

Closing since it was already updated in the other issue as https://github.com/LiskHQ/lisk-sdk/blob/f60042b38f48f15415726d351c8f457c5d685dae/elements/lisk-api-client/src/transaction.ts#L214-L224

@shuse2 shuse2 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shuse2 @mitsuaki-u