This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Reenable and fix skipped Application unit tests - Closes #3947 #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
approved these changes
Jul 16, 2019
framework/test/jest/unit/specs/controller/__snapshots__/application.spec.js.snap
Show resolved
Hide resolved
2snEM6
changed the title
pablitovicente
approved these changes
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Jest Unit tests for
application.jswere skipped and all of them were failing.How did I fix it?
By reenabling them and replacing the faulty
migrations instanceof ArraybyArray.isArray(migrations)which was causing the assertion inregisterMigrationsmethod to throw.How to test it?
Run
npm run jest:unit application.spec.jsReview checklist