Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lisk core upgrade to latest version using Lisk commander failed - Closes #4037 #4079

Merged
merged 3 commits into from
Aug 14, 2019

Conversation

ManuGowda
Copy link
Contributor

@ManuGowda ManuGowda commented Aug 14, 2019

What was the problem?

Commands lisk core install and upgrade failed due to missing default release URL

How did I solve it?

Handled default release URL for install and upgrade

How to manually test it?

cd commander;
npm run build;
./bin/run core:install --network=testnet --no-snapshot --lisk-version=2.0.0-rc.0 lisk-testnet
./bin/run core:status lisk-testnet
./bin/run core:stop lisk-testnet
./bin/run core:start lisk-testnet
./bin/run core:restart lisk-testnet
./bin/run core:upgrade --lisk-version=2.0.1-rc.0 lisk-testnet
./bin/run core:status
./bin/run core:logs lisk-testnet

Review checklist

@ManuGowda ManuGowda changed the base branch from development to release/2.3.0 August 14, 2019 09:18
@ManuGowda ManuGowda self-assigned this Aug 14, 2019
@fchavant
Copy link
Contributor

@ManuGowda the following fails without any clear error message:

lisk@ams3-francois-commander-01:~$ ~/lisk/bin/lisk core:install --network=testnet --no-snapshot foo
  ❯ Install Lisk Core testnet instance as foo
    ✖ Prepare Install Options
      → Cannot read property '0' of null
      Validate root user, flags, prerequisites
      Download Lisk Core Release and Blockchain Snapshot
      Extract Lisk Core
      Register Lisk Core
      Create Database and restore Lisk Blockchain Snapshot
 ›   Error: {"context":{}}

@fchavant
Copy link
Contributor

Those work as expected however:

~/lisk/bin/lisk core:install --network=testnet --no-snapshot --lisk-version=2.0.0-rc.0 bar
~/lisk/bin/lisk core:upgrade bar
~/lisk/bin/lisk core:install --network=testnet --no-snapshot --lisk-version=2.0.0-rc.0 baz
~/lisk/bin/lisk core:upgrade --lisk-version=2.0.1-rc.0 baz

@shuse2
Copy link
Collaborator

shuse2 commented Aug 14, 2019

Same for ./bin/run core:install --network=testnet lisk-testnet

@ManuGowda
Copy link
Contributor Author

Thank you @shuse2 @fchavant for testing I have fixed the issue here is the new build https://jenkins.lisk.io/job/lisk-qa/job/lisk-commander-build-tag/36/

@shuse2 shuse2 merged commit 2202504 into release/2.3.0 Aug 14, 2019
@shuse2 shuse2 deleted the 4037-commander_install_upgrade_bug branch August 14, 2019 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants