This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 456
PeerPool removePeer should allow code or reason as parameter - Closes #4083 #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
reviewed
Aug 14, 2019
ishantiw
approved these changes
Aug 14, 2019
shuse2
approved these changes
Aug 14, 2019
mitsuaki-u
suggested changes
Aug 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but we should also do the following: 1. removePeer
function in PeerPool should be modified to include reason
2. reason
should be added to the removePeer
calls in evictPeer
and removeAllPeers
@mitsujutsu Ready to review. |
mitsuaki-u
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The logs did not show the disconnect reason most of the time.
How did I solve it?
If the status reason is not provided by the other side of the socket, then use the default reason for that code from SocketCluster if it exists.
How to manually test it?
Run tests and check against testnet.
Review checklist