This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add empty signature option - Closes #64670 #6474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i signature account
shuse2
commented
Jun 9, 2021
| readonly minFeePerByte?: number; | ||
| readonly baseFees?: BaseFee[]; | ||
| readonly numberOfSignatures?: number; | ||
| readonly numberOfEmptySignatures?: number; |
There was a problem hiding this comment.
we don't use signatures param in this function, so we need to know how many is required and how many signatures are empty
ManuGowda
approved these changes
Jun 9, 2021
mitsuaki-u
reviewed
Jun 9, 2021
| @@ -37,14 +38,18 @@ const computeTransactionMinFee = ( | |||
| trx: Record<string, unknown>, | |||
| options?: Options, | |||
| ): bigint => { | |||
| const mockSignatures = new Array( | |||
There was a problem hiding this comment.
Is it mock? maybe name it emptySignatures?
There was a problem hiding this comment.
it's both 64bytes and 0 bytes, so empty is not correct I think
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6470
How was it solved?
numberOfEmptySignaturesoption to specify number of empty signatures to include in calculationHow was it tested?