Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Request - Shop by SnowGears #2

Open
TechnoRunner18 opened this issue Jan 15, 2020 · 6 comments
Open

Addon Request - Shop by SnowGears #2

TechnoRunner18 opened this issue Jan 15, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@TechnoRunner18
Copy link

I love the idea of this plugin and would like for you to add support for the following plugin:
LINK: https://www.spigotmc.org/resources/shop-a-simple-intuitive-shop-plugin.9628/

It is a popular premium plugin. If you need help, feel free to contact me. Thank you!

@LittleBigBug
Copy link
Owner

Ok, I'll contact the developer to see if I can get ahold of a copy I can test with. Sorry for the long delay in response. If not, I'll buy it later.

@LittleBigBug LittleBigBug added the enhancement New feature or request label Jan 29, 2020
@LittleBigBug LittleBigBug self-assigned this Jan 29, 2020
@LittleBigBug
Copy link
Owner

Sorry for the lack of updates. The plugin will be a bit harder to include in this open source plugin since pushing the jar file for that plugin in order to build correctly, that would be essentially leaking snowgear's plugin.

I still have to figure out optionally building the plugin without too much hassle if someone needs to build and doesn't own Shop, or if someone creates a fork, I'm trying to mess with maven but it seems kind of hack-y.

See 28a1823

@LittleBigBug
Copy link
Owner

LittleBigBug commented Mar 7, 2020

looking into it further I found that SnowGears has not yet updated this plugin for spigot's 1.15 api.
This plugin is based solely on the 1.15 api, I am not able to develop for this plugin yet. However I have most of the functionality and it just needs testing.

Builds work with or without snowgears shop as of f75e613

@LittleBigBug
Copy link
Owner

LittleBigBug commented Mar 7, 2020

Adding wontfix until this plugin's developer updates to 1.15

@LittleBigBug LittleBigBug added the wontfix This will not be worked on label Mar 7, 2020
@steviebeenz
Copy link
Contributor

Fully updated

@TechnoRunner18
Copy link
Author

Any updates for this request? Shop plugin was updated to MC v1.17. I am using the latest build of AcoWorth v1.6.1 and there seems to be no compatibility yet. Let me know if you need anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants