Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

All downloaded mp3 get corrupted #97

Closed
garlik82 opened this issue Sep 15, 2023 · 18 comments · Fixed by #144
Closed

All downloaded mp3 get corrupted #97

garlik82 opened this issue Sep 15, 2023 · 18 comments · Fixed by #144
Labels
fixed This issue has been fixed and will be available in the next release.

Comments

@garlik82
Copy link

garlik82 commented Sep 15, 2023

Describe the Bug

Plugin works fine, creates Themerr.json and downloads theme.mp3, however all mp3 get corrupted.

Expected Behavior

No response

Additional Context

Running latest linuxserver jellyfin image and nightly Themerr-jellyfin docker mod.
LOGS:

[2023-09-15 10:51:04.807 +01:00] [INF] [132] Jellyfin.Api.Controllers.UniversalAudioController: GetPostedPlaybackInfo profile: DeviceProfile { Name: null, Id: null, Identification: null, FriendlyName: null, Manufacturer: null, ManufacturerUrl: null, ModelName: null, ModelDescription: null, ModelNumber: null, ModelUrl: null, SerialNumber: null, EnableAlbumArtInDidl: False, EnableSingleAlbumArtLimit: False, EnableSingleSubtitleLimit: False, SupportedMediaTypes: "Audio,Photo,Video", UserId: null, AlbumArtPn: null, MaxAlbumArtWidth: null, MaxAlbumArtHeight: null, MaxIconWidth: null, MaxIconHeight: null, MaxStreamingBitrate: 8000000, MaxStaticBitrate: 8000000, MusicStreamingTranscodingBitrate: 128000, MaxStaticMusicBitrate: 8000000, SonyAggregationFlags: null, ProtocolInfo: null, TimelineOffsetSeconds: 0, RequiresPlainVideoItems: False, RequiresPlainFolders: False, EnableMSMediaReceiverRegistrar: False, IgnoreTranscodeByteRangeRequests: False, XmlRootAttributes: [], DirectPlayProfiles: [DirectPlayProfile { Container: "mp3", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "aac", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4a", AudioCodec: "aac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4b", AudioCodec: "aac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "flac", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "alac", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4a", AudioCodec: "alac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4b", AudioCodec: "alac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "webma", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "webm", AudioCodec: "webma", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "wav", AudioCodec: null, VideoCodec: null, Type: Audio }], TranscodingProfiles: [TranscodingProfile { Container: "aac", Type: Audio, VideoCodec: "", AudioCodec: "aac", Protocol: "hls", EstimateContentLength: False, EnableMpegtsM2TsMode: False, TranscodeSeekInfo: Auto, CopyTimestamps: False, Context: Streaming, EnableSubtitlesInManifest: False, MaxAudioChannels: null, MinSegments: 0, SegmentLength: 0, BreakOnNonKeyFrames: False, Conditions: [] }], ContainerProfiles: [], CodecProfiles: [], ResponseProfiles: [], SubtitleProfiles: [] }
[2023-09-15 10:51:04.808 +01:00] [INF] [132] Jellyfin.Api.Helpers.MediaInfoHelper: User policy for "tiagalho". EnableAudioPlaybackTranscoding: True
[2023-09-15 10:51:04.850 +01:00] [INF] [10] Jellyfin.Api.Controllers.UniversalAudioController: GetPostedPlaybackInfo profile: DeviceProfile { Name: null, Id: null, Identification: null, FriendlyName: null, Manufacturer: null, ManufacturerUrl: null, ModelName: null, ModelDescription: null, ModelNumber: null, ModelUrl: null, SerialNumber: null, EnableAlbumArtInDidl: False, EnableSingleAlbumArtLimit: False, EnableSingleSubtitleLimit: False, SupportedMediaTypes: "Audio,Photo,Video", UserId: null, AlbumArtPn: null, MaxAlbumArtWidth: null, MaxAlbumArtHeight: null, MaxIconWidth: null, MaxIconHeight: null, MaxStreamingBitrate: 8000000, MaxStaticBitrate: 8000000, MusicStreamingTranscodingBitrate: 128000, MaxStaticMusicBitrate: 8000000, SonyAggregationFlags: null, ProtocolInfo: null, TimelineOffsetSeconds: 0, RequiresPlainVideoItems: False, RequiresPlainFolders: False, EnableMSMediaReceiverRegistrar: False, IgnoreTranscodeByteRangeRequests: False, XmlRootAttributes: [], DirectPlayProfiles: [DirectPlayProfile { Container: "mp3", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "aac", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4a", AudioCodec: "aac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4b", AudioCodec: "aac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "flac", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "alac", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4a", AudioCodec: "alac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "m4b", AudioCodec: "alac", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "webma", AudioCodec: null, VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "webm", AudioCodec: "webma", VideoCodec: null, Type: Audio }, DirectPlayProfile { Container: "wav", AudioCodec: null, VideoCodec: null, Type: Audio }], TranscodingProfiles: [TranscodingProfile { Container: "aac", Type: Audio, VideoCodec: "", AudioCodec: "aac", Protocol: "hls", EstimateContentLength: False, EnableMpegtsM2TsMode: False, TranscodeSeekInfo: Auto, CopyTimestamps: False, Context: Streaming, EnableSubtitlesInManifest: False, MaxAudioChannels: null, MinSegments: 0, SegmentLength: 0, BreakOnNonKeyFrames: False, Conditions: [] }], ContainerProfiles: [], CodecProfiles: [], ResponseProfiles: [], SubtitleProfiles: [] }
[2023-09-15 10:51:04.852 +01:00] [INF] [10] Jellyfin.Api.Helpers.MediaInfoHelper: User policy for "tiagalho". EnableAudioPlaybackTranscoding: True
[2023-09-15 10:51:05.112 +01:00] [INF] [10] Emby.Server.Implementations.Session.SessionManager: Playback stopped reported by app "Jellyfin Web" "10.8.10" playing "theme". Stopped at "1097" ms
@ReenigneArcher
Copy link
Member

Please test if this is resolved in the lizardbyte/themerr-jellyfin:nightly mod.

@garlik82
Copy link
Author

Hi. I was already using nightly but I rebuilt the container clean the config folder, recreated my server and the same issue persists

@ReenigneArcher
Copy link
Member

Sorry, I missed that in your original issue.

Can you try this commit tag instead? cb76597

It that works then it might be a regression from #86

@ReenigneArcher
Copy link
Member

P.S. It's probably obvious, but you'll need to delete any themes for it to re-download them.

@garlik82
Copy link
Author

garlik82 commented Sep 15, 2023

Sorry, I missed that in your original issue.

Can you try this commit tag instead? cb76597

It that works then it might be a regression from #86

no dice. server is running on a Synology NAS if that is of any help.
I did deleted every json and every mp3 file btw :)

@ReenigneArcher
Copy link
Member

Okay, I'm not sure how to replicate or resolve this at this point.

I wonder if it's an issue with transcoding. Hopefully Jellyfin isn't transcoding themes, but I'm not familiar with the inner workings of JF. Can you play the files in VLC media player?

@garlik82
Copy link
Author

I'll install a test container on my Mac to see if my Synology is the issue. Themes won't play on QuickTime.

@garlik82
Copy link
Author

Same issue running on Mac.

@garlik82
Copy link
Author

garlik82 commented Sep 15, 2023

Installed native jellyfin Mac app, portable themerr-jellyfin, same thing. Checked the YouTube links on the json files and video plays.
Captura de ecrã 2023-09-15, às 17 52 18

This is the error I get when trying to repair the mp3 file.

@ReenigneArcher
Copy link
Member

Okay, I've reported this upstream to YoutubeExplode here: Tyrrrz/YoutubeExplode#738

@ReenigneArcher
Copy link
Member

I think I discovered the issue. I don't think the file is actually corrupted, but I think it is downloading a WebM file instead of an mp3 as it used to.

@garlik82
Copy link
Author

I think I discovered the issue. I don't think the file is actually corrupted, but I think it is downloading a WebM file instead of an mp3 as it used to.

you are correct, changed the extension from mp3 to webm and the file works.

@ReenigneArcher
Copy link
Member

I'm going to wait on a response from upstream to see if we can still directly get an mp3, otherwise I'll find a way to convert it.

@ReenigneArcher
Copy link
Member

@garlik82
Copy link
Author

@garlik82 do you mind testing this build?

https://github.com/LizardByte/Themerr-jellyfin/actions/runs/6203545632?pr=98

worked :)

@ReenigneArcher ReenigneArcher added the fixed This issue has been fixed and will be available in the next release. label Sep 15, 2023
@LizardByte-bot
Copy link
Member

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Sep 15, 2023
7 tasks
@kiam001
Copy link

kiam001 commented Oct 25, 2023

Still issue on offical release

@ReenigneArcher
Copy link
Member

That's why the issue is still open.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants