Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SugarApplicationExceptions aren't passed to IMixinErrorHandler #46

Closed
melontini opened this issue Sep 3, 2023 · 3 comments
Closed

SugarApplicationExceptions aren't passed to IMixinErrorHandler #46

melontini opened this issue Sep 3, 2023 · 3 comments

Comments

@melontini
Copy link

While testing IMixinErrorHandler on Connector, I noticed that Sugar exceptions aren't passed to the handler.

The Mixin in question: [link]

The IMixinErrorHandler in question: [link]

@LlamaLad7
Copy link
Owner

IMixinErrorHandler is very broken generally, e.g. no injection check failures get passed to it. Do you have a particular need for sugar exceptions to be passed to it exclusively? If the underlying behaviour in mixin were improved you would be able to get them by looking at the suppressed exceptions from the injection check failure.

@melontini
Copy link
Author

Ah, wasn't aware of issues with the handler, thank you. (I guess this is what SpongePowered/Mixin#640 is about?)

Anyway, there's no particular need for sugar exceptions. I just assumed this was something to do with sugar exclusively. Sorry.

I'll close this, as this is not an issue with MixinExtras.

@LlamaLad7
Copy link
Owner

Yeah, that getting merged would be ideal.

@LlamaLad7 LlamaLad7 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants