Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "client side error has occurred" after login in on Firefox #98

Closed
Ynng opened this issue Jan 15, 2023 · 4 comments · Fixed by #119
Closed

Fix "client side error has occurred" after login in on Firefox #98

Ynng opened this issue Jan 15, 2023 · 4 comments · Fixed by #119
Assignees
@Ynng @Arcslogger
Labels
bug Something isn't working
Milestone
0.4.1

Comments

@Ynng
Copy link
Member

Ynng commented Jan 15, 2023

No description provided.

@Ynng Ynng self-assigned this Jan 15, 2023
@Ynng Ynng moved this to 💻 In Progress in Lodestone Jan 15, 2023
@Ynng Ynng added this to Lodestone Jan 15, 2023
@CheatCod CheatCod added the bug Something isn't working label Jan 15, 2023
@Ynng Ynng added this to the 0.4.1 milestone Jan 15, 2023
@thorhs
Copy link

thorhs commented Jan 16, 2023

Can confirm, I'm having the same issue. Both with v0.4.0 .deb and a fresh clone/build. Attached are the console messages.
console-export-2023-1-16_20-52-13.txt

@Ynng
Copy link
Member Author

Ynng commented Jan 19, 2023

My current guess is "connecting to a non-secure WebSocket server from a secure origin".

Commenting out all the websocket connections temporarily solves the issue.

In chrome, a warning "Connecting to a non-secure WebSocket server from a secure origin is deprecated" is displayed instead.

@Ynng
Copy link
Member Author

Ynng commented Jan 19, 2023

This is confirmed. Firefox blocks non-secure websocket even in a mixed-content context, since around Firefox 8.

https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_client_applications#security_considerations
https://bugzilla.mozilla.org/show_bug.cgi?id=917829

@Ynng
Copy link
Member Author

Ynng commented Jan 21, 2023

Need to design a warning banner to warn about this issue @Arcslogger

@Ynng Ynng linked a pull request Jan 26, 2023 that will close this issue
Issue 98: firefox crash when using insecure websocket in a mixed content context #119
Merged
@Ynng Ynng closed this as completed Jan 28, 2023
@github-project-automation github-project-automation bot moved this from 💻 In Progress to ✔ Done in Lodestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ynng Ynng

@Arcslogger Arcslogger

Labels
bug Something isn't working
Projects
Lodestone
Status: ✔ Done
Milestone
0.4.1
4 participants
@thorhs @Ynng @CheatCod @Arcslogger