Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GHA refs validation check the whole branch name (OSOE-814) #334

Open
Piedone opened this issue Feb 14, 2024 · 0 comments
Open

Make GHA refs validation check the whole branch name (OSOE-814) #334

Piedone opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Piedone
Copy link
Member

Piedone commented Feb 14, 2024

Currently, you can merge a PR without having the correct branch references in action/worfklow references, and Validate GitHub Actions Refs won't prevent this, if the target branch's name is a substring of the source branch (e.g. the target is task/gha-refs-validate-without-merge-queue and the source is task/gha-refs-validate-without-merge-queue-test-pr). This is most possibly due to using a pattern instead of an exact match.

This should be changed so the exact branch references are enforced.

This is not a huge issue currently, because the only branch we have it guarding is dev, and source branches will never be dev*.

Jira issue

@Piedone Piedone added the bug Something isn't working label Feb 14, 2024
@github-actions github-actions bot changed the title Make GHA refs validation check the whole branch name Make GHA refs validation check the whole branch name (OSOE-814) Feb 14, 2024
@Piedone Piedone added the good first issue Good for newcomers label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant