Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run baseline package validation during NuGet publishing for major version changes (OSOE-857) #350

Closed
Piedone opened this issue May 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented May 15, 2024

To allow breaking changes in major versions, something that the baseline package validator we use during NuGet publishing doesn't do (see dotnet/sdk#40907), let's not run it in such cases.

So, if New-NuGetPackage notices a major version change (e.g. from 1.2.3 to 2.0.0) then disable baseline package validation (but only that, package validation should otherwise run).

If dotnet/sdk#40907 is implemented before, then this won't be needed.

Jira issue

@Piedone Piedone added the enhancement New feature or request label May 15, 2024
@github-actions github-actions bot changed the title Don't run baselines package validation during NuGet publishing for major version changes Don't run baselines package validation during NuGet publishing for major version changes (OSOE-857) May 15, 2024
@Piedone Piedone changed the title Don't run baselines package validation during NuGet publishing for major version changes (OSOE-857) Don't run baseline package validation during NuGet publishing for major version changes (OSOE-857) May 18, 2024
@Piedone
Copy link
Member Author

Piedone commented May 21, 2024

@sarahelsaig
Copy link
Member

No, when I pushed a major tag it always worked.

@Piedone
Copy link
Member Author

Piedone commented May 22, 2024

That's what I remembered doing before, but still, I had to do Lombiq/UI-Testing-Toolbox@803e87f to publish a new major version. It failed under https://github.com/Lombiq/UI-Testing-Toolbox/actions/runs/9100082776/job/25014098526 without it.

@Piedone
Copy link
Member Author

Piedone commented Nov 3, 2024

This seems to br working well now.

@Piedone Piedone closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants