Skip to content
This repository has been archived by the owner on Jan 23, 2019. It is now read-only.

Allow to submit changes for original strings #156

Open
smichel17 opened this issue Oct 16, 2017 · 5 comments
Open

Allow to submit changes for original strings #156

smichel17 opened this issue Oct 16, 2017 · 5 comments

Comments

@smichel17
Copy link

If I'd like to send a PR suggesting an update to the phrasing of English/source strings, I don't see why that should be prevented. Seems like an easy win :)

@Lonami
Copy link
Member

Lonami commented Oct 17, 2017

The original string is kept as readonly because if you modified it there would be no turning back, other than synchronizing again. So perhaps a better approach would be to have a special locale "Fix up" or "Patches" (please suggest more names!) for the original translation, that would simply be initialized with a fresh copy of the English (default locale) strings.

@smichel17
Copy link
Author

smichel17 commented Oct 17, 2017

From a ui perspective, I would not do it any differently than any other language: Allow modifying the [English] translation (the same way it's possible to modify any other 100% translated language), and exporting it via clipboard, gist, PR, etc. Keep the "original string" field as-is until changes are merged to origin/master.

On the backend, that probably means either caching the source strings or loading them from the index instead of the working directory. However, that's just an implementation detail to me.

@Lonami
Copy link
Member

Lonami commented Oct 17, 2017

Problem is the default locale may not be English. There's no way to tell this, so "[English]" wouldn't be a valid name.

Yes, the implementation would be something like a "special" locale which would just be special on creation/exporting to pull request. Nothing really fancy. The thing is, what name should we give to this locale?

@smichel17
Copy link
Author

I meant the brackets to indicate I knew it wouldn't always be English, lol.

They use "Default" here. I think "Source" or "Master" would also work well. Or just adding slightly more description, like, "Default (all locales)".

@gsantner
Copy link
Contributor

values-fix :D

@gsantner gsantner changed the title Allow translating to the source language Allow to submit changes for original strings May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants