Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show previous carb entries that are active after midnight #840

Closed
elnjensen opened this issue Oct 22, 2018 · 5 comments
Closed

Show previous carb entries that are active after midnight #840

elnjensen opened this issue Oct 22, 2018 · 5 comments
Labels

Comments

@elnjensen
Copy link
Contributor

elnjensen commented Oct 22, 2018

Since Loop resets the carb display at midnight, it is not possible after that to edit a previous entry, even if the carbs are still active. This limits a user's options for tweaking carb amount or timing if it turns out to be incorrect, if the absorption window crosses the midnight boundary.

A fix could be to always show any entry that hasn't yet expired. (This is related to #681, but distinct as this is not only about the display, but editing of active carbs).

@cfaagaard
Copy link
Contributor

cfaagaard commented Oct 29, 2018

Maybe ICE-result could be sent to Nightscout? Maybe updating the treatment with actual carb-entry. Then one could see it in the treatment-report fx in the note field.
This could be very useful for a parent/follower with a kid on "the Loop".

ice

@Nightfoxy
Copy link

I believe this issue has been addressed, but I think the absorption for the entry that is from the previous day (prior to midnight) is not using the ISF from yesterday, but switches to using the ISF defined at midnight for absorption. I think this is a separate issue.

Should this issue be closed?

@NightScoutForSeb
Copy link

I still experience this frequently with high fat/high protein boluses from the night before that were set to 6h absorption but should have been 8h absorption. I can’t go back and edit them after the fact.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 17, 2023
Copy link

github-actions bot commented Dec 1, 2023

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants