Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuota_packges buffers can overflow #19

Closed
MpmTwtg opened this issue Sep 25, 2023 · 2 comments
Closed

fuota_packges buffers can overflow #19

MpmTwtg opened this issue Sep 25, 2023 · 2 comments

Comments

@MpmTwtg
Copy link

MpmTwtg commented Sep 25, 2023

The ans_index is able to overflow fmp_tx_payload_ans.

ctx->fmp_tx_payload_ans[ans_index++] = FMP_PKG_VERSION_ANS;

The reason behind this is that it loops and can fill the buffer as long ass there are msg's, but the buffer is as big as the biggest package.

while( fmp_package_rx_buffer_length > fmp_package_rx_buffer_index )

uint8_t fmp_tx_payload_ans[FMP_SIZE_ANS_MAX];

This can also happen in
lorawan_fragmentation_package.c
and possible in remote_multicast_tx_payload_ans
The same problems occurs in fuota_packages_v2

@lbm-team
Copy link
Contributor

lbm-team commented Oct 4, 2023

Thank you for your feedback, this issue will be fixed in the next release

@lbm-team
Copy link
Contributor

Hi @MpmTwtg

This issue is now fixed in new v4.3.0 release and mentioned in CHANGELOG.

Once more thanks for your report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants