New command ideas

[LoricAndre]

I need ideas for new commands, so comment here anything you might want !

[aMOPel]

What you think about a command that opens just a terminal in the current workspace to run some quick code while editing. But the terminal is persistent, so that you can execute your program or whatever, esc out, edit some, use some other one term commands, come back to the terminal, and you still have the output etc.
I just like the floating thing more than the standard neovim term.

[LoricAndre]

This should be feasible, I'll look into it
EDIT : done with 25b41e1 to 886d951
EDIT2: I'll document shortly, I forgot

[aMOPel]

so how do you exit it again? since it captures all the keyinput, because by typing exit of course you kill the instance.

[LoricAndre]

You can use <C-\><C-n> to get back to normal mode

[aMOPel]

alright, but it doesnt stop rendering the floating window, i can jump outside but the floating window is still in front and if i close it with "c-w c" my vim crashes.
free(): invalid size
zsh: abort (core dumped) nvim -S ./Session.vim

[LoricAndre]

I'm looking into this, a stable version should be up shortly.

[LoricAndre]

Well it should be working now

[LoricAndre]

And btw you still need to close the window when you're down (if you delete the buffer it will open a new shell instance).

[aMOPel]

first i got this error when closing the window
Error executing vim.schedule lua callback: vim.lua:492: Vim(source):E484: Can't open file /tmp/o
neterm

then i manually created the file and had no error when closing the windows, but still calling ":OneTerm term" again opens a new instance, old output is gone

[LoricAndre]

The first issue is easy to fix and I'll work on it tomorrow (meaning in ~16h)
How do you close the window ? The file should be created anyway unless you exit the shell early

[aMOPel]

so i exit terminal mode with <c-\><c-n> and then use <c-w>c which i didnt remap which executes :close

[LoricAndre]

All right, it's weird cause I tested it by closing it this way. Can you check if g:oneterm_term_buf changes every time you open a new window?

[aMOPel]

it does indeed, went from 9 to 10

[LoricAndre]

All right, thanks, I'll look into it tomorrow. The other commands are working for you (apart for #3)?

[aMOPel]

well files isnt working since it depends on rg and i only have ag currently (and fd-find ) but thats to be expected.

now that i tested :OneTerm buffers i saw that the terms are actually there

the :OneTerm make listed some makefiles but it didnt compile on enter, also without the path of the makefile im missing the context which is which, also im getting no targets, only makefiles. but im using <leader>m for compiling and have a dedicated .exrc file in the project root to set makeprg because i also specify a -C flag for the command

symbols works for me, i have nvim-lspconfig, but ws_symbols doesnt give me anything

also what i noticed is that its a little annoying that for every match with fzf there is the full absolute path, usually there is little space left for the actual match, so maybe an omision or a compression of parts of the path would be nice.

also another idea would be to add snippet search

[aMOPel]

references is giving me results but opens nonsense ~/learncpp/src/main.cpp 27 Mystring string{ this is the buffer name and the buffer is empty when i jump to a reference

[aMOPel]

and yank isnt working for me i have let g:var_oneterm_yank = 1 in my vimrc and i get

Error detected while processing function Oneterm_cmd: line 2: E5108: Error executing lua [string "luaeval()"]:1: attempt to call field 'yank' (a nil value)

is there some dependency or smth?

[basilgood]

It would be great if OneTerm commits were colorful.
It's almost useless without syntax because it's hard to see the diffs.
And would be useful OneTerm bcommits to see diffs for current buffer only.
For OneTerm rg it would be useful if the results had line numbers.
Thanks for your work.

[LoricAndre]

also what i noticed is that its a little annoying that for every match with fzf there is the full absolute path, usually there is little space left for the actual match, so maybe an omision or a compression of parts of the path would be nice.

Could you please open an issue for this please ? It will take some time & work but I'll try

[LoricAndre]

and yank isnt working for me i have let g:var_oneterm_yank = 1 in my vimrc and i get

Error detected while processing function Oneterm_cmd: line 2: E5108: Error executing lua [string "luaeval()"]:1: attempt to call field 'yank' (a nil value)

is there some dependency or smth?

The actual command is yanks, The s is missing from the completion function and doc. I'll push this soon

[aMOPel]

I see, also the last time I looked term wasn't in the completions

[basilgood]

Neovim has now native floating border.
It could be easy to put in function getopts() local opt: border = 'single'

[LoricAndre]

Neovim has now native floating border.
It could be easy to put in function getopts() local opt: border = 'single'

I saw this, that's why I created g:oneterm_options, you can simply put it in there !

[LoricAndre]

I fixed most of the issues above, apart from @aMOPel 's term issue, ws_symbols and make. I've also added bcommits.

[LoricAndre]

The paths on the lsp matching are now relative btw

[LoricAndre]

@aMOPel could you also please open an issue for the problem you have with term please ? I can't reproduce it...

[LoricAndre]

the :OneTerm make listed some makefiles but it didnt compile on enter, also without the path of the makefile im missing the context which is which, also im getting no targets, only makefiles. but im using <leader>m for compiling and have a dedicated .exrc file in the project root to set makeprg because i also specify a -C flag for the command>

Did you run the command with a Makefile in neovim's working directory ?

[aMOPel]

the :OneTerm make listed some makefiles but it didnt compile on enter, also without the path of the makefile im missing the context which is which, also im getting no targets, only makefiles. but im using <leader>m for compiling and have a dedicated .exrc file in the project root to set makeprg because i also specify a -C flag for the command>

Did you run the command with a Makefile in neovim's working directory ?

not in the root of the working directory but in a folder 1 below

[LoricAndre]

will you add a snippet search?

I'll try to, at least with UltiSnips there has to be a way since fzf.vim did it

[basilgood]

Oldfiles or History it would be useful.

[LoricAndre]

Do you mean command history ?

[LoricAndre]

Oldfiles is done !

[aMOPel]

Oldfiles is done !

for recent files you could use the .fasd file if fasd is installed

[aMOPel]

the :OneTerm make listed some makefiles but it didnt compile on enter, also without the path of the makefile im missing the context which is which, also im getting no targets, only makefiles. but im using <leader>m for compiling and have a dedicated .exrc file in the project root to set makeprg because i also specify a -C flag for the command>

Did you run the command with a Makefile in neovim's working directory ?

not in the root of the working directory but in a folder 1 below

Ok that's why it isn't working, I'm only detecting targets for neovim's pwd. I'll try making the plugin walk a few directories up

i mean i work with cmake and it makes a folder for debug for example and in there is the makefile generated. however i make the project root vims working dir and have a session file there from which i continue working. and then i have a .exrc set makeprg=make\ -C\ ./debug so i can call :make in vim, but i guess i could also symlink the makefile in the root.
but then what about different builds like release..
ex:
vim working dir is just project/
project/src/main.cpp etc.
project/debug/makefile

I'll try using makeprg then !
EDIT : done with 2938f81

works for me

[LoricAndre]

History done (it lists command history) !

[LoricAndre]

Oldfiles is done !

for recent files you could use the .fasd file if fasd is installed

I'm not using that but it seems interesting !
EDIT : For files you've edited in neovim, it keeps a list in v:oldfiles so I don't really need it

[basilgood]

Wow you're awesome. Oldfiles it's what I wanted.
Thank you very much.
It works perfectly.

[basilgood]

An awesome feature would be term to be toggle and keep the session.

[LoricAndre]

This is how it's supposed to work, see #5 for progress and the issue and to help me debug it !
EDIT : you need set hidden for it to work since I have to keep the buffer alive

[basilgood]

I watched the debugging on the #5 but it doesn't work for me.
set hidden? hidden
OneTerm term open terminal
<C-\><C-n> and OneTerm term
and nothing happens.
maybe I'm doing something wrong?

[LoricAndre]

<C-\><C-n> will put you in normal mode, you have to close the window afterwards. Then, invoking the command again should open the same terminal instance

[basilgood]

Yes, I tested it and it works perfectly.
Thank you.

[aMOPel]

Yes, I tested it and it works perfectly.
Thank you.

you can use this mapping to easily close it
tnoremap <c-w> <c-\><c-n><c-w>c

[basilgood]

I have this:

vimp.nmap([[<C-\>]], ":OneTerm term<cr>")
vimp.tnoremap([[<C-\>]], '<C-\\><C-n>:q<cr>')

Thank you.

[basilgood]

I wonder if we could not use the framework to not clutter the plugin ?
If I want to change gitui with lazygit or if I want to change the default
cmd from OneTerm files,
Or if I want to add something new: open ~/.config/nvim or open current dir...
Or if I want OpenTerm to follow my colorscheme...
A few examples would make this easier.

[LoricAndre]

You can check init.lua for examples, don't hesitate to open an issue for any questions you might have !

[LoricAndre]

Snippets are added, I'd love some feedback

[basilgood]

Snippets are added, I'd love some feedback

on nvim start:

[LoricAndre]

Oh yeah I'm an idiot this is linked to #7 which I've reopened. Everything should work otherwise

[basilgood]

Yes everything works

[dcordb]

@LoricAndre what about integrating the functionality of this plugin https://github.com/dominickng/fzf-session.vim ? I use this to have a quick access to my sessions.

[LoricAndre]

This seems easy enough, I'll start working on it

[LoricAndre]

Sorry for the delay, with the end of term, plus I was moving and starting an internship, so I didn't have much time in the past weeks

[LoricAndre]

Sessions should be done with dcbeec6 !

[qvieth]

@LoricAndre can you make using "ranger in OneTerm term" same as "OneTerm ranger", also the same for fzf,rg,... this plugin is so cool btw

[LoricAndre]

Hi, do you mean that when you use ranger in the neovim terminal opened by OneTerm term you'd want it to open the file into a new buffer in the main neovim instance ? This sounds interesting, I'll try to think about it but I'm not sure it's doable from the plugin, this might be doable through scripting and neovim-remote

[qvieth]

Yes! Thank you, @LoricAndre ! Love the idea of 1 terminal rules them all!! This plugin is so convenient!