Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you select classification to view, view number doesn't update #74

Open
eepeacock opened this issue Nov 26, 2018 · 4 comments
Open

If you select classification to view, view number doesn't update #74

eepeacock opened this issue Nov 26, 2018 · 4 comments

Comments

@eepeacock
Copy link

If you open a batch of files to annotate and there are say 30 views, and you use the name menu, "select classification to view," The number that the view is on does not change, it is still at 1. Then you can't advance by clicking "next", "next" takes you back to view 2.

@LouisK130
Copy link
Owner

This behavior is intentional, as it's the simplest way to handle the situation.

The 30 views are sorted into a "timeline" that you can step through with "next" and "previous". This is purely a convenience thing to ensure you see all the views that you originally expressed interest in. If you choose to leave this timeline by manually jumping to a different view, you're welcome to, but it becomes non-obvious where you belong when you want to come back. Perhaps you selected a view that wasn't even part of the original 30. Even if you did select one of the 30, I'm not sure it's desirable that jumping from view 1 to view 29 and then pressing "next" should take you to view 30. You'll miss all of 2 through 28.

Let me know if this doesn't make sense to you, or you think there's a better way.

@eepeacock
Copy link
Author

So if I move something to a class that is later in the "timeline", will it be added to the view list? That is the behavior I would expect but it occurs to me this may not be the case in the current version.

@LouisK130
Copy link
Owner

The 30 original views are fixed. Moving an image to a view that is not one of those 30 will not add a 31st view to the timeline. This "new" view would only contain images you had already seen or images that you had not originally expressed interest in.

However, if you move an image to a later view that is already part of the timeline (say you're in view 2 and you classify an image such that it now belongs in view 5), you will see that image again when you reach view 5. We could potentially hide that image when you reach view 5 on the basis that you've already looked at it, but at the moment that doesn't seem critical.

@eepeacock
Copy link
Author

I'm still thinking on this topic. There are two types of cases:

  1. I selected views in the view selection area. In this case, I think the current functionality makes sense.
  2. I selected a bunch of files and want to see all views. In this case, I would expected to function more like version 1 of ifcb-annotate, where next and previous are in relation to the class I am currently viewing and any classes containing ROIs are included in the views. I guess if it is a lot of programming to add the newly populated classes to the views, that is the less important item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants