Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QML - show: item.valid not working after including Venus OS v3.00~14 #469

Closed
mr-manuel opened this issue Feb 20, 2023 · 1 comment
Closed

Comments

@mr-manuel
Copy link
Collaborator

Describe the bug
All items in the QML file that are validated to show or not are displayed indipendent of the result.

To Reproduce
Steps to reproduce the behavior:
Update to the latest v3.00 Venus OS firmware.

Expected behavior
Not valid items should not be shown.

Screenshots
grafik

VenusOS (please complete the following information):

  • Device type: [e.g. VenusGX, Cerbo, Raspberry Pi]
  • Firmware Version: >= v3.00~14

Additional context

MbRowSmall, MbTextBlock and Text objects do not support the 'show' parameter. These objects did support show prior to v3.00~14.
The 'show' parameter for objects inside a VisualItemModel do not hide the item in v3.00~14 as they did in previous Venus OS versions. This is a known issue, just making readers aware.
https://community.victronenergy.com/questions/179527/bug-hiding-gui-objects-not-working.html?childToView=180447#answer-180447

VisibleItemModel will not work prior v3.00~14 and will result in a blank GUI.

@kwindrem solved it that way:
https://github.com/kwindrem/SetupHelper/blob/87274c481fc0e5b61f259ee2e0bd9b07d4dec4f6/setup#L91-L105

https://github.com/kwindrem/SetupHelper/blob/ebaa65fcf23e2bea6797f99c1c41174143c1153c/updateFileSets#L56-L81

head -n 1 /opt/victronenergy/version

I will open a pull request later.

@mr-manuel
Copy link
Collaborator Author

Commited to open pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant