When adding a comment block to the end of a file and hitting "enter" within the code block the files contents are cleared

[muppet9010]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Formatting

Expected Behaviour

That it doesn't clear the files content. No real action is required from the formatter during this action.

Actual Behaviour

That it's clearing the files contents.

Reproduction steps

Have a new file with some content, add a comment block to the end of the file and add a new line within the content block, the file is cleared.

I know its Sumneko as it doesn't happen when I disable the extension. It only started in the last version or 2.

Start with file content:

local x = 1 

Press enter a few times to get some empty lines

Type --[[ and it auto completes the closing ]], leaving the cursor in the middle of the command block.

Press enter to add a new line, with the intention of typing within the comment block. The file is cleared at this point.

Video of the issue occuring.

Additional Notes

No response

Log File

file_c%3A_Home_Projects_Factorio%20Modding_Factorio-JD-Plays.log
service.log

[sumneko]

@CppCXY

[CppCXY]

I can't reproduce, can others reproduce it?
currently you can choose to turn off format on type

[muppet9010]

ah balls, I forgot I had a Sumneko plugin present.
When I remove the plugin the issue doesn't occur.
Tried with and without the plugin twice and its reproducible. I will raise with the plugin maker.
Sorry.

[CppCXY]

I reproduce this, by install the plugin. maybe the result of 'type on format' is handled by plugin mechanism, or error handling by plugin.

[muppet9010]

So the plugin creator made a suggestion, which they believe shows its a Sumneko core issue and not a Plugin specific issue.

I added a dummy plugin to my workspace, set the plugin path to this and the issue still occurred.
I confirmed the real plugin wasn't being loaded, as the real plugin changes the scope of a global variable called global to include the workspace name, but in this test the global scope was still just global.

Dummy plugin:

root of workspace\plugin\plugin.lua

function OnSetText()
  return {}
end

Set Sumneko to use this dummy plugin at the workspace settings level:
"Lua.runtime.plugin": "/plugin/plugin.lua"

I close VS Code, make the changes and then open it up clean.

Reproduced issue with this dummy plugin active then used "undo" to return the code back to how it was at the fresh load.
log.zip

If I set my plugin path setting to be empty string "" in my workspace settings (so it overrides my user setting) then I don't see any issue.

[sumneko]

I cannot reproduce it, did you triggered formatting?
Please try to disable formatthing/range formating/type formating.

[sumneko]

I can reproduce it with range formatting now.