Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated parameter hints when using workspace with multiple folders #377

Closed
iTob191 opened this issue Feb 3, 2021 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@iTob191
Copy link

iTob191 commented Feb 3, 2021

Describe the bug
When using the workspace feature of VS Code, the extension seems to launch a separate instance of the language server for each folder of the workspace. This works fine initially, but after saving a file the instances start interfering and for example parameter hints and some diagnostics are duplicated.
I'm also not sure whether it is intended, that multiple "😺 Lua" are shown in the left part of the status bar in the above case.

To Reproduce
Steps to reproduce the behavior:

  1. Create a workspace with 2 folders and some lua file in each workspace.
  2. Open a file of the first folder.
  3. Open a file of the second folder.
  4. Press Ctrl+S
  5. See error

Expected behavior
Parameter hints are not duplicated.

Screenshots

tyGYDVlggmlluPaQpkbP.mp4

Environment (please complete the following information):

  • OS: Windows
  • Is WSL remote? No
  • Client: VSCode (all other extensions disabled)
@sumneko
Copy link
Collaborator

sumneko commented Feb 3, 2021

Should be fixed by LuaLS/vscode-lua@114d9c5

This feature is not provided by LSP. I tried to implement it using TS myself, so there will be many problems.
Another known issue is that if you view a file in multiple windows, Hint can only be displayed in one of the windows. I currently don't have a good solution to this problem. After all, I am not good at TS.

@sumneko sumneko added the bug Something isn't working label Feb 3, 2021
@Immow
Copy link

Immow commented Feb 3, 2021

image
Is this related to that issue?
I'm just starting out in programming so I don't know if these are the same things. Suddenly those :numbers started showing up.

Reverting back to v1.13.0 fixed my problem

@iTob191
Copy link
Author

iTob191 commented Feb 3, 2021

What you're seeing is not a bug, but a new feature. This can be disabled with the config options: Lua.hint.paramType and Lua.hint.setType (just paste these name into the search bar in the settings panel). You can also just disable all such hints using Lua.hint.enable.

@Immow
Copy link

Immow commented Feb 3, 2021

What you're seeing is not a bug, but a new feature. This can be disabled with the config options: Lua.hint.paramType and Lua.hint.setType (just paste these name into the search bar in the settings panel). You can also just disable all such hints using Lua.hint.enable.

Thank you, that was indeed the "problem" :)

@sumneko sumneko closed this as completed in 6e7c082 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants