Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When renaming fields/methods, references get not renamed (in different files) #647

Closed
sewbacca opened this issue Aug 14, 2021 · 2 comments
Labels
bug Something isn't working feat/LuaCats Annotations Related to Lua Language Server Annotations (LuaCats)
Milestone

Comments

@sewbacca
Copy link
Contributor

Describe the bug
When renaming a method from an objects point of view, the method is getting renamed and the definition is getting renamed as well, but all known instances of the class wont get renamed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a class and two instances
  2. Create a method and invoke them by these two instances (one in another file).
  3. Rename the method from one of the instances
  4. See that the other one won't get renamed

Expected behavior
Either errormessage renaming from objects POV or rename all referenced methods.

Screenshots
Animation.gif

Environment (please complete the following information):

  • OS: Windows
  • Client: VSCode

Additional Context
Apparently same issue with classes.

@sumneko sumneko added bug Something isn't working feat/LuaCats Annotations Related to Lua Language Server Annotations (LuaCats) labels Aug 17, 2021
@sumneko sumneko added this to the 2.4.0 milestone Aug 24, 2021
@sumneko
Copy link
Collaborator

sumneko commented Aug 24, 2021

They should be fixed in 2.3.7, please check out it

@sewbacca
Copy link
Contributor Author

sewbacca commented Aug 28, 2021

Well the problem moved, now there is this issue:
still-wont-work.gif
But class renaming works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat/LuaCats Annotations Related to Lua Language Server Annotations (LuaCats)
Projects
None yet
Development

No branches or pull requests

2 participants