Add selector_mode field to chains

This opens up more options for handling selector results. It also allows us to simplify the dynamic select chain input process, to just a single template.
LucasPickering · Sep 19, 2024 · c97904e · c97904e
1 parent 1d16067
commit c97904e
Show file tree

Hide file tree

Showing 13 changed files with 250 additions and 386 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
   - When using the CLI, the `--profile` argument can be omitted to use the default profile
 - Reset edited recipe values to their default using `r`
   - You can [customize the key](https://slumber.lucaspickering.me/book/api/configuration/input_bindings.html) to whatever you want
+- Add `selector_mode` field to chains, to control how single vs multiple results from a JSONPath selector are handled
+  - Previously, if a selector returned multiple results, an error was returned. Now, the result list will be rendered as a JSON array. To return to the previous behavior, set `selector_mode: single` in your chain.
+  - [See docs for more](https://slumber.lucaspickering.me/book/api/request_collection/chain.html#selector-mode)
 
 ### Changed
 

diff --git a/crates/core/src/collection.rs b/crates/core/src/collection.rs
@@ -280,6 +280,7 @@ mod tests {
                     source: ChainSource::command(["whoami"]),
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -291,6 +292,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -299,6 +301,7 @@ mod tests {
                     source: ChainSource::command(["whoami"]),
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -307,6 +310,7 @@ mod tests {
                     source: ChainSource::command(["whoami"]),
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::Start,
                 },
@@ -315,6 +319,7 @@ mod tests {
                     source: ChainSource::command(["whoami"]),
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::End,
                 },
@@ -323,6 +328,7 @@ mod tests {
                     source: ChainSource::command(["whoami"]),
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::Both,
                 },
@@ -334,6 +340,7 @@ mod tests {
                     },
                     sensitive: true,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -345,6 +352,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -355,6 +363,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -365,6 +374,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: Some(ContentType::Json),
                     trim: ChainOutputTrim::None,
                 },
@@ -377,6 +387,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: Some("$.data".parse().unwrap()),
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -389,6 +400,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -401,6 +413,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -415,6 +428,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -427,6 +441,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -439,6 +454,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },
@@ -453,6 +469,7 @@ mod tests {
                     },
                     sensitive: false,
                     selector: None,
+                    selector_mode: SelectorMode::default(),
                     content_type: None,
                     trim: ChainOutputTrim::None,
                 },