Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset edited values #386

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Reset edited values #386

merged 1 commit into from
Sep 17, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Sep 17, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Reset edited recipe values with r

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

It's easy to accidentally reset a value, because there's no confirmation. This could be mitigated with a confirmation dialog, but I don't think it's worth it because the overrides are meant to be temporary anyway, so losing it shouldn't be catastrophic.

QA

How did you test this?

Added unit tests, tested manually in TUI

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) September 17, 2024 23:43
@LucasPickering LucasPickering merged commit 8d74182 into master Sep 17, 2024
15 checks passed
@LucasPickering LucasPickering deleted the reset-edited-values branch September 17, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant