Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-deprecate {{env.VARIABLE}} source #387

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

LucasPickering
Copy link
Owner

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

I originally deprecated this when I added the !env chain source, but if all you're doing is reading a static variable, this is a simple alternative. It costs very little to continue to support this so I think it's worth keeping around.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

Higher complexity with more features supported.

QA

How did you test this?

Doc change only

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) September 18, 2024 12:47
@LucasPickering LucasPickering merged commit 1d16067 into master Sep 18, 2024
15 checks passed
@LucasPickering LucasPickering deleted the dedeprecate-env-source branch September 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant