Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for recent commits #232

Open
dstansby opened this issue Sep 15, 2023 · 1 comment
Open

Add tests for recent commits #232

dstansby opened this issue Sep 15, 2023 · 1 comment
Labels

Comments

@dstansby
Copy link
Contributor

👋 @bryan-harter, it would be good to add some tests to the test suite to make sure the fixes you recently made in versions 1.1.1 and 1.1.2 stay fixed in the future.

@dstansby dstansby added the Bug label Sep 15, 2023
@bryan-harter
Copy link
Collaborator

Yes sorry I've kinda been rushing the commits, we're using cdflib to write the CDF files for the IMAP mission (specifically, xarray_to_cdf), so I wanted to get things fixed quickly so the different instruments could get started on CDF generation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants