Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt CDF generation from IMAP code #271

Open
bryan-harter opened this issue Jul 16, 2024 · 0 comments
Open

Corrupt CDF generation from IMAP code #271

bryan-harter opened this issue Jul 16, 2024 · 0 comments

Comments

@bryan-harter
Copy link
Collaborator

bryan-harter commented Jul 16, 2024

In Ana's commit over here: https://github.com/anamanica/imap_processing/blob/71885c9232fddf1bff590bf39be71f83ad0826cb/imap_processing/cdf/config/imap_idex_l1_variable_attrs.yaml#L42

cdflib was able to create a corrupt cdf file. Specifically, cdflib had the correct attribute entry stuff, but the data was either too long or too short for the data type. It might be an issue with specifically with VALIDMIN and FILLVAL being strings, I'm not entirely sure. But there should be a check added that ensures that the data is not ever created with, say, an 8 bit numerical type, but we give cdflib a string of 200 characters for the data instead.

The first thing we'll need to do is create a minimal code sample that replicates the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant