Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something with submitted MESA_RUN_OPTIONAL data in submissions #25

Closed
wmwolf opened this issue Nov 18, 2020 · 2 comments
Closed

Do something with submitted MESA_RUN_OPTIONAL data in submissions #25

wmwolf opened this issue Nov 18, 2020 · 2 comments
Assignees

Comments

@wmwolf
Copy link
Member

wmwolf commented Nov 18, 2020

Submitted test instances now "know" when they came from running optional inlists. This should be saved into the database with the instances (and submissions) so that we can later search on them, they don't create spurious multiple checksum errors, don't pollute runtime statistics, etc.

@wmwolf wmwolf self-assigned this Nov 18, 2020
@jschwab
Copy link
Contributor

jschwab commented Dec 17, 2020

Test cases will also know if MESA_FPE_CHECKS_ON is set via the fpe_checks field. Lumping that in here rather than creating a separate issue, since it presumably requires similar handling.

@wmwolf
Copy link
Member Author

wmwolf commented Dec 17, 2020

At present, both of these statuses are now recorded in the database and are indicated in any list views showing individual test instances (viewing results of a test case for a particular commit or looking at history of instances from a particular computer for a particular test case).

Furthermore, run_optional instances are ignored in determining how many distinct checksums there are, so we won't get erroneous warnings for mixed checksums, even if there are distinct checksums between different instances that run optional inlists.

As the morning mailer (#17) gets rebuilt, we'll use this to filter out instances in determining average runtimes (and memory usage, maybe?).

@wmwolf wmwolf closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants