Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malformed validation scenarios fail silently when running for Job #431

Closed
ghukill opened this issue Jun 28, 2019 · 3 comments
Closed

malformed validation scenarios fail silently when running for Job #431

ghukill opened this issue Jun 28, 2019 · 3 comments
Assignees

Comments

@ghukill
Copy link
Contributor

ghukill commented Jun 28, 2019

Schematron based validation scenario that has an XML error with the schematron, fails silently when applied and running for a Job.

However, when testing that scenario against a single record in Combine (via the GUI), the error is apparent, e.g.:

Opening and ending tag mismatch: rule line 33 and pattern, line 34, column 12 (file_3fb170911b114205a51b6a7ecdc5484b.sch, line 34)

Would be beneficial to inform user that a Validation Scenario was erroring for records when running for a Job, instead of failing quietly.

Thoughts/Questions:

  • perhaps the "validation" tab in a Job details page should show errors, in addition to valid/invalid?
  • should a Job get marked as invalid when errors are reported to be conservative with thinking a Job / Records are valid? (tried applying validation, didn't work, assume we don't know about the validity of the records)
  • how to bubble up errors from Spark?
    • each time a Record fails a validation, a corresponding RecordValidation instance is created
    • wonder if this could record the error that occurred during validation? treat the Record as if it failed validation (and in a sense it did), and instead of recording why the validation failed, record the error as best as possible?
@ghukill
Copy link
Contributor Author

ghukill commented Jun 28, 2019

Not yet tested with:

  • python code snippet validation scenarios
  • Elasticsearch query validation scenarios

@antmoth antmoth self-assigned this Jun 28, 2019
@antmoth
Copy link
Collaborator

antmoth commented Jul 1, 2019

I'm not entirely sure this is part of this ticket? If not, I can split it out:
image

@antmoth
Copy link
Collaborator

antmoth commented Jul 5, 2019

YASS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants