Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server stalls on Autosave of large annotation data #201

Closed
joakimlindblad opened this issue Jan 27, 2022 · 3 comments
Closed

Server stalls on Autosave of large annotation data #201

joakimlindblad opened this issue Jan 27, 2022 · 3 comments
Assignees

Comments

@joakimlindblad
Copy link
Member

joakimlindblad commented Jan 27, 2022

For larger Annotation data, > 5000 markers

In extendHistory()
if (diff.diffJson(JSON.parse(data), JSON.parse(oldData)).length === 1)
seems like an extremely slow way to check if data has changed

Can we not just have a counter, or a checksum, or something?

@joakimlindblad
Copy link
Member Author

And, also, diff.createPatch stalls; should/can we use Google's diff-match-patch instead?
See: kpdecker/jsdiff#239

@joakimlindblad
Copy link
Member Author

@joakimlindblad
Copy link
Member Author

Resolved by PR #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants