Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect disparity range manipulation #188

Open
gfacciol opened this issue Feb 2, 2019 · 0 comments
Open

incorrect disparity range manipulation #188

gfacciol opened this issue Feb 2, 2019 · 0 comments
Assignees

Comments

@gfacciol
Copy link
Contributor

gfacciol commented Feb 2, 2019

This line (and surrounding code) is in charge of extending the disparity range for the stereo matching:

disp_min *= (1 - np.sign(disp_min) * cfg['disp_range_extra_margin'])

But these manipulations are incorrect. If disp_min=0 to begin with, then no multiplication will ever increase the disparity range. The correct way to increase the disparity range is with:

dmin-= (dmax-dmin)* cfg['disp_range_extra_margin'])
dmax+= (dmax-dmin)* cfg['disp_range_extra_margin'])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants