Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS_INTEGRATION_ENABLED flag, instead of relying on AWS_VERIFICATION_BUCKET_NAME to determine whether AWS Cloud integration is visible to user #2306

Open
tompollard opened this issue Sep 29, 2024 · 0 comments

Comments

@tompollard
Copy link
Member

In our env file, there is a variable called "AWS_VERIFICATION_BUCKET_NAME". The absence/presence of this variable is used to determine whether the site should display AWS related content on the site, via the following function:

def aws_verification_available():
"""
Check whether the site is configured for AWS account authentication.
"""
return bool(settings.AWS_VERIFICATION_BUCKET_NAME)

It would be more intuitive (readable/explicit) to have a AWS_INTEGRATION_ENABLED flag. Probably the same applies for our Google Cloud integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant