Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report progress of individual test cases #1

Closed
4 of 7 tasks
jevakallio opened this issue Jun 11, 2020 · 5 comments
Closed
4 of 7 tasks

Report progress of individual test cases #1

jevakallio opened this issue Jun 11, 2020 · 5 comments

Comments

@jevakallio
Copy link

jevakallio commented Jun 11, 2020

Start point for the problem

The above issues were tackled, but still under review/progress as mentioned in the PR jestjs#9001.

Continued issues

The original PR jestjs#9001 mentioned above has been kinda stale for some time. So we get started by -

  • Currently, this PR has a mix of both eventEmitters and callbacks to jest-circus. I suggest we go for eventEmitters only solution. Although the project currently handles communication via callbacks, as discussed in here: Report progress of individual test cases jestjs/jest#6616 (comment) and mentioned by Simen in the call itself, it is eventually planned to shift to emitters.

    This can be an experimental API, so doesn't become a breaking change (if this gets accepted).
    Something like

    testRunnter.__EXPERIMENTAL_supportsEventEmmiters__

    (Though I don't have much idea, how to shift the current callbacks methods to eventEmitters, as it will create a sequence of changes. We might stick to current methods, if implementing eventEmitters is getting hard, maybe create a separate issue for it. Someone could help here)

  • Wrapping up the custom message emit from the testReporter.

    • Currently has a single custom message .onCustomMessage(cb) extended on the interface for the Reporter [Refer BaseReporter class]. It can be split up into
      onTestRun - all files in all runners
      onTestFile - one file
      onTest - one test/it
      onDescribeBlock - one describe
      onAssertion - one expect call

      as discussed in the issue Report progress of individual test cases jestjs/jest#6616 (comment)

Would be great if someone shared or added thoughts on this 😅

@sauravhiremath
Copy link
Member

@jevakallio @kunal-kushwaha would be great if any suggestions or changes added to this :D

@kunal-kushwaha
Copy link
Member

I believe this is a good start:
jestjs#9662 is a breakdown for jestjs#9001

@sauravhiremath
Copy link
Member

sauravhiremath commented Jun 12, 2020

I believe this is a good start:
facebook#9662 is a breakdown for facebook#9001

Yeah I went through this PR yesterday and implemented the same on my local machine, it did achieve the goals listed on the PR. There were some reviews left by Simen there.

Though they weren't responded by the PR author, should we mention on the original PR facebook#9662 that we would be continuing from that, and add subsequent progress to facebook#9001 ? @jevakallio

Edit: It didn't seem right, coz @rogeliog has worked a lot since Oct 19 (afaik). So ...

@kunal-kushwaha
Copy link
Member

PR merged 🎉

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants